[giow] (3) Make the 'supported property names' unenumerable on object…

…s that descend from HTMLCollection. Fixing https://www.w3.org/Bugs/Public/show_bug.cgi?id=25123 Affected topics: DOM APIs, Microdata git-svn-id: http://svn.whatwg.org/webapps@8599 340c8d12-0b0e-0410-8428-c7bf67bfef74
whatwg · May 2, 2014 · c1de476 · c1de476
1 parent c3861d8
commit c1de476
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 0 deletions.
diff --git a/complete.html b/complete.html
@@ -7640,6 +7640,8 @@ <h5 id=htmlallcollection-0><span class=secno>2.7.2.1 </span>HTMLAllCollection</h
   preceding its <code title="">name</code> if it contributes both, they differ from each other, and neither
   is the duplicate of an earlier entry.</p>
 
+  <p>The properties exposed in this way must be <a href=#unenumerable>unenumerable</a>.</p>
+
   <p>The <dfn id=dom-htmlallcollection-item-string title=dom-HTMLAllCollection-item-string><code>item(<var title="">name</var>)</code></dfn> and <dfn id=dom-htmlallcollection-nameditem title=dom-HTMLAllCollection-namedItem><code>namedItem(<var title="">name</var>)</code></dfn>
   methods must act according to the following algorithm:</p>
 
@@ -7720,6 +7722,8 @@ <h5 id=htmlformcontrolscollection-0><span class=secno>2.7.2.2 </span>HTMLFormCon
   duplicates, with the <code title=attr-id><a href=#the-id-attribute>id</a></code> of an element preceding its <code title=attr-fe-name><a href=#attr-fe-name>name</a></code> if it contributes both, they differ from each other, and neither is the
   duplicate of an earlier entry.</p>
 
+  <p>The properties exposed in this way must be <a href=#unenumerable>unenumerable</a>.</p>
+
   <p>The <dfn id=dom-htmlformcontrolscollection-nameditem title=dom-HTMLFormControlsCollection-namedItem><code>namedItem(<var title="">name</var>)</code></dfn> method must act according to the following algorithm:</p>
 
   <ol><li>If <var title="">name</var> is the empty string, return null and stop the algorithm.</li>
@@ -7852,6 +7856,8 @@ <h5 id=htmloptionscollection-0><span class=secno>2.7.2.3 </span>HTMLOptionsColle
   duplicates, with the <code title=attr-id><a href=#the-id-attribute>id</a></code> of an element preceding its <code title=attr-option-name><a href=#attr-option-name>name</a></code> if it contributes both, they differ from each other, and neither is
   the duplicate of an earlier entry.</p>
 
+  <p>The properties exposed in this way must be <a href=#unenumerable>unenumerable</a>.</p>
+
   <p>The <dfn id=dom-htmloptionscollection-nameditem title=dom-HTMLOptionsCollection-namedItem>legacy caller</dfn> of the
   <code><a href=#htmloptionscollection>HTMLOptionsCollection</a></code> interface must act like the <code title=dom-HTMLCollection-namedItem>namedItem()</code> method on the ancestor
   <code><a href=#htmlcollection>HTMLCollection</a></code> interface.</p>
@@ -7994,6 +8000,8 @@ <h5 id=htmlpropertiescollection-0><span class=secno>2.7.2.4 </span>HTMLPropertie
   elements <a href=#represented-by-the-collection>represented by the collection</a>, in <a href=#tree-order>tree order</a>, ignoring later
   duplicates.</p>
 
+  <p>The properties exposed in this way must be <a href=#unenumerable>unenumerable</a>.</p>
+
   <p>The <dfn id=dom-htmlpropertiescollection-names title=dom-HTMLPropertiesCollection-names><code>names</code></dfn> attribute must
   return a <a href=#live>live</a> <a href=#dfn-read-only-array title=dfn-read-only-array>read only</a> array object giving
   the <a href=#property-names>property names</a> of all the elements <a href=#represented-by-the-collection>represented by the collection</a>,

diff --git a/index b/index
@@ -7640,6 +7640,8 @@ a.setAttribute('href', 'http://example.com/'); // change the content attribute d
   preceding its <code title="">name</code> if it contributes both, they differ from each other, and neither
   is the duplicate of an earlier entry.</p>
 
+  <p>The properties exposed in this way must be <a href=#unenumerable>unenumerable</a>.</p>
+
   <p>The <dfn id=dom-htmlallcollection-item-string title=dom-HTMLAllCollection-item-string><code>item(<var title="">name</var>)</code></dfn> and <dfn id=dom-htmlallcollection-nameditem title=dom-HTMLAllCollection-namedItem><code>namedItem(<var title="">name</var>)</code></dfn>
   methods must act according to the following algorithm:</p>
 
@@ -7720,6 +7722,8 @@ interface <dfn id=radionodelist>RadioNodeList</dfn> : <a href=#nodelist>NodeList
   duplicates, with the <code title=attr-id><a href=#the-id-attribute>id</a></code> of an element preceding its <code title=attr-fe-name><a href=#attr-fe-name>name</a></code> if it contributes both, they differ from each other, and neither is the
   duplicate of an earlier entry.</p>
 
+  <p>The properties exposed in this way must be <a href=#unenumerable>unenumerable</a>.</p>
+
   <p>The <dfn id=dom-htmlformcontrolscollection-nameditem title=dom-HTMLFormControlsCollection-namedItem><code>namedItem(<var title="">name</var>)</code></dfn> method must act according to the following algorithm:</p>
 
   <ol><li>If <var title="">name</var> is the empty string, return null and stop the algorithm.</li>
@@ -7852,6 +7856,8 @@ http://software.hixie.ch/utilities/js/live-dom-viewer/?%3C%21DOCTYPE%20html%3E..
   duplicates, with the <code title=attr-id><a href=#the-id-attribute>id</a></code> of an element preceding its <code title=attr-option-name><a href=#attr-option-name>name</a></code> if it contributes both, they differ from each other, and neither is
   the duplicate of an earlier entry.</p>
 
+  <p>The properties exposed in this way must be <a href=#unenumerable>unenumerable</a>.</p>
+
   <p>The <dfn id=dom-htmloptionscollection-nameditem title=dom-HTMLOptionsCollection-namedItem>legacy caller</dfn> of the
   <code><a href=#htmloptionscollection>HTMLOptionsCollection</a></code> interface must act like the <code title=dom-HTMLCollection-namedItem>namedItem()</code> method on the ancestor
   <code><a href=#htmlcollection>HTMLCollection</a></code> interface.</p>
@@ -7994,6 +8000,8 @@ interface <dfn id=propertynodelist>PropertyNodeList</dfn> : <a href=#nodelist>No
   elements <a href=#represented-by-the-collection>represented by the collection</a>, in <a href=#tree-order>tree order</a>, ignoring later
   duplicates.</p>
 
+  <p>The properties exposed in this way must be <a href=#unenumerable>unenumerable</a>.</p>
+
   <p>The <dfn id=dom-htmlpropertiescollection-names title=dom-HTMLPropertiesCollection-names><code>names</code></dfn> attribute must
   return a <a href=#live>live</a> <a href=#dfn-read-only-array title=dfn-read-only-array>read only</a> array object giving
   the <a href=#property-names>property names</a> of all the elements <a href=#represented-by-the-collection>represented by the collection</a>,

diff --git a/source b/source
@@ -7100,6 +7100,8 @@ a.setAttribute('href', 'http://example.com/'); // change the content attribute d
   preceding its <code data-x="">name</code> if it contributes both, they differ from each other, and neither
   is the duplicate of an earlier entry.</p>
 
+  <p>The properties exposed in this way must be <span>unenumerable</span>.</p>
+
   <p>The <dfn data-x="dom-HTMLAllCollection-item-string"><code>item(<var
   data-x="">name</var>)</code></dfn> and <dfn
   data-x="dom-HTMLAllCollection-namedItem"><code>namedItem(<var data-x="">name</var>)</code></dfn>
@@ -7197,6 +7199,8 @@ interface <dfn>RadioNodeList</dfn> : <span>NodeList</span> {
   data-x="attr-fe-name">name</code> if it contributes both, they differ from each other, and neither is the
   duplicate of an earlier entry.</p>
 
+  <p>The properties exposed in this way must be <span>unenumerable</span>.</p>
+
   <p>The <dfn data-x="dom-HTMLFormControlsCollection-namedItem"><code>namedItem(<var
   data-x="">name</var>)</code></dfn> method must act according to the following algorithm:</p>
 
@@ -7367,6 +7371,8 @@ http://software.hixie.ch/utilities/js/live-dom-viewer/?%3C%21DOCTYPE%20html%3E..
   data-x="attr-option-name">name</code> if it contributes both, they differ from each other, and neither is
   the duplicate of an earlier entry.</p>
 
+  <p>The properties exposed in this way must be <span>unenumerable</span>.</p>
+
   <p>The <dfn data-x="dom-HTMLOptionsCollection-namedItem">legacy caller</dfn> of the
   <code>HTMLOptionsCollection</code> interface must act like the <code
   data-x="dom-HTMLCollection-namedItem">namedItem()</code> method on the ancestor
@@ -7535,6 +7541,8 @@ interface <dfn>PropertyNodeList</dfn> : <span>NodeList</span> {
   elements <span>represented by the collection</span>, in <span>tree order</span>, ignoring later
   duplicates.</p>
 
+  <p>The properties exposed in this way must be <span>unenumerable</span>.</p>
+
   <p>The <dfn data-x="dom-HTMLPropertiesCollection-names"><code>names</code></dfn> attribute must
   return a <span>live</span> <span data-x="dfn-read-only-array">read only</span> array object giving
   the <span>property names</span> of all the elements <span>represented by the collection</span>,