[giow] (3) Make sure .click() doesn't fire on disabled form controls.

Fixing https://www.w3.org/Bugs/Public/show_bug.cgi?id=24404 Affected topics: DOM APIs, HTML git-svn-id: http://svn.whatwg.org/webapps@8421 340c8d12-0b0e-0410-8428-c7bf67bfef74
whatwg · Jan 27, 2014 · 200c5a5 · 200c5a5
1 parent 39793f2
commit 200c5a5
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 8 deletions.
diff --git a/complete.html b/complete.html
@@ -75511,10 +75511,13 @@ <h3 id=activation><span class=secno>8.3 </span>Activation</h3>
 
   </dl><div class=impl>
 
-  <p>The <dfn id=dom-click title=dom-click><code>click()</code></dfn> method must <a href=#run-synthetic-click-activation-steps>run synthetic click
-  activation steps</a> on the element.</p>
+  <p>The <dfn id=dom-click title=dom-click><code>click()</code></dfn> method must run the following steps:</p>
 
-  </div>
+  <ol><li><p>If the element is a form control that is <a href=#concept-fe-disabled title=concept-fe-disabled>disabled</a>, abort these steps.</li>
+
+   <li><p><a href=#run-synthetic-click-activation-steps>Run synthetic click activation steps</a> on the element.</li>
+
+  </ol></div>
 <!--TOPIC:HTML-->
 
 
@@ -102494,6 +102497,7 @@ <h2 class=no-num id=references>References</h2><!--REFS-->
   Elliott Sprehn,
   Elliotte Harold,
   Eric Carlson,
+  Eric Casler,
   Eric Lawrence,
   Eric Rescorla,
   Eric Semling,

diff --git a/index b/index
@@ -75511,10 +75511,13 @@ loadMySprites().then(runDemo);</pre>
 
   </dl><div class=impl>
 
-  <p>The <dfn id=dom-click title=dom-click><code>click()</code></dfn> method must <a href=#run-synthetic-click-activation-steps>run synthetic click
-  activation steps</a> on the element.</p>
+  <p>The <dfn id=dom-click title=dom-click><code>click()</code></dfn> method must run the following steps:</p>
 
-  </div>
+  <ol><li><p>If the element is a form control that is <a href=#concept-fe-disabled title=concept-fe-disabled>disabled</a>, abort these steps.</li>
+
+   <li><p><a href=#run-synthetic-click-activation-steps>Run synthetic click activation steps</a> on the element.</li>
+
+  </ol></div>
 <!--TOPIC:HTML-->
 
 
@@ -102494,6 +102497,7 @@ if (s = prompt('What is your name?')) {
   Elliott Sprehn,
   Elliotte Harold,
   Eric Carlson,
+  Eric Casler,
   Eric Lawrence,
   Eric Rescorla,
   Eric Semling,

diff --git a/source b/source
@@ -84462,8 +84462,16 @@ loadMySprites().then(runDemo);</pre>
 
   <div class="impl">
 
-  <p>The <dfn data-x="dom-click"><code>click()</code></dfn> method must <span>run synthetic click
-  activation steps</span> on the element.</p>
+  <p>The <dfn data-x="dom-click"><code>click()</code></dfn> method must run the following steps:</p>
+
+  <ol>
+
+   <li><p>If the element is a form control that is <span
+   data-x="concept-fe-disabled">disabled</span>, abort these steps.</p></li>
+
+   <li><p><span>Run synthetic click activation steps</span> on the element.</p></li>
+
+  </ol>
 
   </div>
 <!--TOPIC:HTML-->
@@ -114480,6 +114488,7 @@ if (s = prompt('What is your name?')) {
   Elliott Sprehn,
   Elliotte Harold,
   Eric Carlson,
+  Eric Casler,
   Eric Lawrence,
   Eric Rescorla,
   Eric Semling,