[giow] (0) Make non-scripted <dialog> closing not throw uncaught exce…

…ptions. Fixing https://www.w3.org/Bugs/Public/show_bug.cgi?id=23478 Affected topics: CSS, HTML git-svn-id: http://svn.whatwg.org/webapps@8344 340c8d12-0b0e-0410-8428-c7bf67bfef74
whatwg · Dec 11, 2013 · 84bdaa9 · 84bdaa9
1 parent 860bb4d
commit 84bdaa9
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 6 deletions.
diff --git a/complete.html b/complete.html
@@ -48979,7 +48979,8 @@ <h5 id=form-submission-algorithm><span class=secno>4.10.22.3 </span>Form submiss
 
       <p>Let <var title="">subject</var> be the nearest ancestor <code><a href=#the-dialog-element>dialog</a></code> element of <var title="">form</var>, if any.</p>
 
-      <p>If there isn't one, do nothing. Otherwise, proceed as follows:</p>
+      <p>If there isn't one, or if it does not have an <code title=attr-dialog-open><a href=#attr-dialog-open>open</a></code>
+      attribute, do nothing. Otherwise, proceed as follows:</p>
 
       <p>If <var title="">submitter</var> is an <code><a href=#the-input-element>input</a></code> element whose <code title=attr-input-type><a href=#attr-input-type>type</a></code> attribute is in the <a href="#image-button-state-(type=image)" title=attr-input-type-image>Image Button</a> state, then let <var title="">result</var>
       be the string formed by concatenating the <a href=#concept-input-type-image-coordinate title=concept-input-type-image-coordinate>selected coordinate</a>'s <var title="">x</var>-component, expressed as a base-ten number using <a href=#ascii-digits>ASCII digits</a>, a
@@ -51154,7 +51155,8 @@ <h4 id=the-dialog-element><span class=secno>4.11.7 </span>The <dfn><code>dialog<
   <hr><p><strong>Canceling dialogs</strong>: When a <code><a href=#document>Document</a></code>'s <a href=#pending-dialog-stack>pending dialog
   stack</a> is not empty, user agents may provide a user interface that, upon activation, <a href=#queue-a-task title="queue a task">queues a task</a> to <a href=#fire-a-simple-event>fire a simple event</a> named <dfn id=event-cancel title=event-cancel><code>cancel</code></dfn> that is cancelable at the top <code><a href=#the-dialog-element>dialog</a></code>
   element on the <code><a href=#document>Document</a></code>'s <a href=#pending-dialog-stack>pending dialog stack</a>. The default action of
-  this event must be to <a href=#close-the-dialog>close the dialog</a> with no return value.</p>
+  this event must be to check if that element has an <code title=attr-dialog-open><a href=#attr-dialog-open>open</a></code>
+  attribute, and if it does, <a href=#close-the-dialog>close the dialog</a> with no return value.</p>
 
   <p class=note>An example of such a UI mechanism would be the user pressing the "Escape" key.</p>
 

diff --git a/index b/index
@@ -48979,7 +48979,8 @@ fur
 
       <p>Let <var title="">subject</var> be the nearest ancestor <code><a href=#the-dialog-element>dialog</a></code> element of <var title="">form</var>, if any.</p>
 
-      <p>If there isn't one, do nothing. Otherwise, proceed as follows:</p>
+      <p>If there isn't one, or if it does not have an <code title=attr-dialog-open><a href=#attr-dialog-open>open</a></code>
+      attribute, do nothing. Otherwise, proceed as follows:</p>
 
       <p>If <var title="">submitter</var> is an <code><a href=#the-input-element>input</a></code> element whose <code title=attr-input-type><a href=#attr-input-type>type</a></code> attribute is in the <a href="#image-button-state-(type=image)" title=attr-input-type-image>Image Button</a> state, then let <var title="">result</var>
       be the string formed by concatenating the <a href=#concept-input-type-image-coordinate title=concept-input-type-image-coordinate>selected coordinate</a>'s <var title="">x</var>-component, expressed as a base-ten number using <a href=#ascii-digits>ASCII digits</a>, a
@@ -51154,7 +51155,8 @@ dictionary <dfn id=relatedeventinit>RelatedEventInit</dfn> : <a href=#eventinit>
   <hr><p><strong>Canceling dialogs</strong>: When a <code><a href=#document>Document</a></code>'s <a href=#pending-dialog-stack>pending dialog
   stack</a> is not empty, user agents may provide a user interface that, upon activation, <a href=#queue-a-task title="queue a task">queues a task</a> to <a href=#fire-a-simple-event>fire a simple event</a> named <dfn id=event-cancel title=event-cancel><code>cancel</code></dfn> that is cancelable at the top <code><a href=#the-dialog-element>dialog</a></code>
   element on the <code><a href=#document>Document</a></code>'s <a href=#pending-dialog-stack>pending dialog stack</a>. The default action of
-  this event must be to <a href=#close-the-dialog>close the dialog</a> with no return value.</p>
+  this event must be to check if that element has an <code title=attr-dialog-open><a href=#attr-dialog-open>open</a></code>
+  attribute, and if it does, <a href=#close-the-dialog>close the dialog</a> with no return value.</p>
 
   <p class=note>An example of such a UI mechanism would be the user pressing the "Escape" key.</p>
 

diff --git a/source b/source
@@ -53875,7 +53875,8 @@ fur
       <p>Let <var data-x="">subject</var> be the nearest ancestor <code>dialog</code> element of <var
       data-x="">form</var>, if any.</p>
 
-      <p>If there isn't one, do nothing. Otherwise, proceed as follows:</p>
+      <p>If there isn't one, or if it does not have an <code data-x="attr-dialog-open">open</code>
+      attribute, do nothing. Otherwise, proceed as follows:</p>
 
       <p>If <var data-x="">submitter</var> is an <code>input</code> element whose <code
       data-x="attr-input-type">type</code> attribute is in the <span
@@ -56466,7 +56467,8 @@ dictionary <dfn>RelatedEventInit</dfn> : <span>EventInit</span> {
   data-x="queue a task">queues a task</span> to <span>fire a simple event</span> named <dfn
   data-x="event-cancel"><code>cancel</code></dfn> that is cancelable at the top <code>dialog</code>
   element on the <code>Document</code>'s <span>pending dialog stack</span>. The default action of
-  this event must be to <span>close the dialog</span> with no return value.</p>
+  this event must be to check if that element has an <code data-x="attr-dialog-open">open</code>
+  attribute, and if it does, <span>close the dialog</span> with no return value.</p>
 
   <p class="note">An example of such a UI mechanism would be the user pressing the "Escape" key.</p>