[giow] (0) Don't make default='' tracks hidden if the user has config…

…ured the browser to automatically select another. Fixing https://www.w3.org/Bugs/Public/show_bug.cgi?id=18893 Affected topics: Video Text Tracks git-svn-id: http://svn.whatwg.org/webapps@7556 340c8d12-0b0e-0410-8428-c7bf67bfef74
whatwg · Dec 1, 2012 · 7717583 · 7717583
1 parent 79af11f
commit 7717583
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 22 deletions.
diff --git a/complete.html b/complete.html
@@ -32854,13 +32854,16 @@ <h6 id=sourcing-out-of-band-text-tracks><span class=secno>4.8.10.12.3 </span>Sou
     <p>If the user has expressed an interest in having a track from <var title="">candidates</var>
     enabled based on its <a href=#text-track-kind>text track kind</a>, <a href=#text-track-language>text track language</a>, and
     <a href=#text-track-label>text track label</a>, then set its <a href=#text-track-mode>text track mode</a> to <a href=#text-track-showing title="text
-    track showing">showing</a>, and if there are any <a href=#text-track title="text track">text tracks</a>
-    in <var title="">candidates</var> that correspond to <code><a href=#the-track-element>track</a></code> elements with a <code title=attr-track-default><a href=#attr-track-default>default</a></code> attribute set whose <a href=#text-track-mode>text track mode</a> is
-    set to <a href=#text-track-disabled title="text track disabled">disabled</a>, then additionally set the <a href=#text-track-mode>text
-    track mode</a> of the first such track to <a href=#text-track-hidden title="text track hidden">hidden</a>.</p>
-    <!-- so that we still get events and stuff: we can expect authors to forget that default doesn't
-    mean that it'll always be turned on, and that they'll still rely on events firing even if it
-    doesn't show -->
+    track showing">showing</a><!--, and if there are any <span title="text track">text
+    tracks</span> in <var title="">candidates</var> that correspond to <code>track</code> elements
+    with a <code title="attr-track-default">default</code> attribute set whose <span>text track
+    mode</span> is set to <span title="text track disabled">disabled</span>, then additionally set
+    the <span>text track mode</span> of the first such track to <span title="text track
+    hidden">hidden</span>-->.</p> <!-- the idea behind the commented out stuff is that we still get
+    events and stuff: we can expect authors to forget that default doesn't mean that it'll always be
+    turned on, and that they'll still rely on events firing even if it doesn't show. But it is
+    commented out, because we can equally expect authors to expect only one track is getting events,
+    so we've got problems either way, and might as well go with the simpler behaviour. -->
 
     <p class=note>For example, the user could have set a browser preference to the effect of "I
     want French captions whenever possible", or "If there is a subtitle track with 'Commentary' in

diff --git a/index b/index
@@ -32854,13 +32854,16 @@ interface <dfn id=mediacontroller>MediaController</dfn> : <a href=#eventtarget>E
     <p>If the user has expressed an interest in having a track from <var title="">candidates</var>
     enabled based on its <a href=#text-track-kind>text track kind</a>, <a href=#text-track-language>text track language</a>, and
     <a href=#text-track-label>text track label</a>, then set its <a href=#text-track-mode>text track mode</a> to <a href=#text-track-showing title="text
-    track showing">showing</a>, and if there are any <a href=#text-track title="text track">text tracks</a>
-    in <var title="">candidates</var> that correspond to <code><a href=#the-track-element>track</a></code> elements with a <code title=attr-track-default><a href=#attr-track-default>default</a></code> attribute set whose <a href=#text-track-mode>text track mode</a> is
-    set to <a href=#text-track-disabled title="text track disabled">disabled</a>, then additionally set the <a href=#text-track-mode>text
-    track mode</a> of the first such track to <a href=#text-track-hidden title="text track hidden">hidden</a>.</p>
-    <!-- so that we still get events and stuff: we can expect authors to forget that default doesn't
-    mean that it'll always be turned on, and that they'll still rely on events firing even if it
-    doesn't show -->
+    track showing">showing</a><!--, and if there are any <span title="text track">text
+    tracks</span> in <var title="">candidates</var> that correspond to <code>track</code> elements
+    with a <code title="attr-track-default">default</code> attribute set whose <span>text track
+    mode</span> is set to <span title="text track disabled">disabled</span>, then additionally set
+    the <span>text track mode</span> of the first such track to <span title="text track
+    hidden">hidden</span>-->.</p> <!-- the idea behind the commented out stuff is that we still get
+    events and stuff: we can expect authors to forget that default doesn't mean that it'll always be
+    turned on, and that they'll still rely on events firing even if it doesn't show. But it is
+    commented out, because we can equally expect authors to expect only one track is getting events,
+    so we've got problems either way, and might as well go with the simpler behaviour. -->
 
     <p class=note>For example, the user could have set a browser preference to the effect of "I
     want French captions whenever possible", or "If there is a subtitle track with 'Commentary' in

diff --git a/source b/source
@@ -35722,14 +35722,16 @@ interface <dfn>MediaController</dfn> : <span>EventTarget</span> {
     <p>If the user has expressed an interest in having a track from <var title="">candidates</var>
     enabled based on its <span>text track kind</span>, <span>text track language</span>, and
     <span>text track label</span>, then set its <span>text track mode</span> to <span title="text
-    track showing">showing</span>, and if there are any <span title="text track">text tracks</span>
-    in <var title="">candidates</var> that correspond to <code>track</code> elements with a <code
-    title="attr-track-default">default</code> attribute set whose <span>text track mode</span> is
-    set to <span title="text track disabled">disabled</span>, then additionally set the <span>text
-    track mode</span> of the first such track to <span title="text track hidden">hidden</span>.</p>
-    <!-- so that we still get events and stuff: we can expect authors to forget that default doesn't
-    mean that it'll always be turned on, and that they'll still rely on events firing even if it
-    doesn't show -->
+    track showing">showing</span><!--, and if there are any <span title="text track">text
+    tracks</span> in <var title="">candidates</var> that correspond to <code>track</code> elements
+    with a <code title="attr-track-default">default</code> attribute set whose <span>text track
+    mode</span> is set to <span title="text track disabled">disabled</span>, then additionally set
+    the <span>text track mode</span> of the first such track to <span title="text track
+    hidden">hidden</span>-->.</p> <!-- the idea behind the commented out stuff is that we still get
+    events and stuff: we can expect authors to forget that default doesn't mean that it'll always be
+    turned on, and that they'll still rely on events firing even if it doesn't show. But it is
+    commented out, because we can equally expect authors to expect only one track is getting events,
+    so we've got problems either way, and might as well go with the simpler behaviour. -->
 
     <p class="note">For example, the user could have set a browser preference to the effect of "I
     want French captions whenever possible", or "If there is a subtitle track with 'Commentary' in