Skip to content

Commit

Permalink
[giow] (1) Avoid firing enter/exit events on cues that have just been…
Browse files Browse the repository at this point in the history
… introduced, e.g. when a track is enabled, since that's just crazy.

Fixing https://www.w3.org/Bugs/Public/show_bug.cgi?id=17235
Affected topics: Video and Audio

git-svn-id: http://svn.whatwg.org/webapps@7329 340c8d12-0b0e-0410-8428-c7bf67bfef74
  • Loading branch information
Hixie committed Sep 11, 2012
1 parent fb93d0c commit 89d50d4
Show file tree
Hide file tree
Showing 3 changed files with 62 additions and 2 deletions.
22 changes: 21 additions & 1 deletion complete.html
Expand Up @@ -31729,7 +31729,21 @@ <h5 id=playing-the-media-resource><span class=secno>4.8.10.8 </span>Playing the
unpaused, or it could be unpaused but stalled waiting for content to
buffer.</p>

<hr><p>When the <a href=#current-playback-position>current playback position</a> of a <a href=#media-element>media
<hr><p>Each <a href=#media-element>media element</a> has a <span>list of newly
introduced cues</span>, which must be initially empty. Whenever a
<a href=#text-track-cue>text track cue</a> is added to the <a href=#text-track-list-of-cues title="text track
list of cues">list of cues</a> of a <a href=#text-track>text track</a> that
is in the <a href=#list-of-text-tracks>list of text tracks</a> for a <a href=#media-element>media
element</a>, that <a href=#text-track-cue title="text track cue">cue</a> must be
added to the <a href=#media-element>media element</a>'s <span>list of newly
introduced cues</span>. Whenever a <a href=#text-track>text track</a> is added
to the <a href=#list-of-text-tracks>list of text tracks</a> for a <a href=#media-element>media
element</a>, all of the <a href=#text-track-cue title="text track cue">cues</a>
in that <a href=#text-track>text track</a>'s <a href=#text-track-list-of-cues title="text track list of
cues">list of cues</a> must be added to the <a href=#media-element>media
element</a>'s <span>list of newly introduced cues</span>.</p>

<p>When the <a href=#current-playback-position>current playback position</a> of a <a href=#media-element>media
element</a> changes (e.g. due to playback or seeking), the user
agent must run the following steps. If the <a href=#current-playback-position>current playback
position</a> changes while the steps are running, then the user
Expand Down Expand Up @@ -31769,6 +31783,12 @@ <h5 id=playing-the-media-resource><span class=secno>4.8.10.8 </span>Playing the
equal to the <a href=#current-playback-position>current playback position</a>. Otherwise, let
<var title="">missed cues</var> be an empty list.</li>

<li><p>Remove all the <a href=#text-track-cue title="text track cue">cues</a> in
<var title="">missed cues</var> that are also in the <a href=#media-element>media
element</a>'s <span>list of newly introduced cues</span>, and
then empty the element's <span>list of newly introduced
cues</span>.</li>

<li><p>If the time was reached through the usual monotonic increase
of the <a href=#current-playback-position>current playback position</a> during normal
playback, and if the user agent has not fired a <code title=event-media-timeupdate><a href=#event-media-timeupdate>timeupdate</a></code> event at the
Expand Down
22 changes: 21 additions & 1 deletion index
Expand Up @@ -31729,7 +31729,21 @@ interface <dfn id=htmlaudioelement>HTMLAudioElement</dfn> : <a href=#htmlmediael
unpaused, or it could be unpaused but stalled waiting for content to
buffer.</p>

<hr><p>When the <a href=#current-playback-position>current playback position</a> of a <a href=#media-element>media
<hr><p>Each <a href=#media-element>media element</a> has a <span>list of newly
introduced cues</span>, which must be initially empty. Whenever a
<a href=#text-track-cue>text track cue</a> is added to the <a href=#text-track-list-of-cues title="text track
list of cues">list of cues</a> of a <a href=#text-track>text track</a> that
is in the <a href=#list-of-text-tracks>list of text tracks</a> for a <a href=#media-element>media
element</a>, that <a href=#text-track-cue title="text track cue">cue</a> must be
added to the <a href=#media-element>media element</a>'s <span>list of newly
introduced cues</span>. Whenever a <a href=#text-track>text track</a> is added
to the <a href=#list-of-text-tracks>list of text tracks</a> for a <a href=#media-element>media
element</a>, all of the <a href=#text-track-cue title="text track cue">cues</a>
in that <a href=#text-track>text track</a>'s <a href=#text-track-list-of-cues title="text track list of
cues">list of cues</a> must be added to the <a href=#media-element>media
element</a>'s <span>list of newly introduced cues</span>.</p>

<p>When the <a href=#current-playback-position>current playback position</a> of a <a href=#media-element>media
element</a> changes (e.g. due to playback or seeking), the user
agent must run the following steps. If the <a href=#current-playback-position>current playback
position</a> changes while the steps are running, then the user
Expand Down Expand Up @@ -31769,6 +31783,12 @@ interface <dfn id=htmlaudioelement>HTMLAudioElement</dfn> : <a href=#htmlmediael
equal to the <a href=#current-playback-position>current playback position</a>. Otherwise, let
<var title="">missed cues</var> be an empty list.</li>

<li><p>Remove all the <a href=#text-track-cue title="text track cue">cues</a> in
<var title="">missed cues</var> that are also in the <a href=#media-element>media
element</a>'s <span>list of newly introduced cues</span>, and
then empty the element's <span>list of newly introduced
cues</span>.</li>

<li><p>If the time was reached through the usual monotonic increase
of the <a href=#current-playback-position>current playback position</a> during normal
playback, and if the user agent has not fired a <code title=event-media-timeupdate><a href=#event-media-timeupdate>timeupdate</a></code> event at the
Expand Down
20 changes: 20 additions & 0 deletions source
Expand Up @@ -34625,6 +34625,20 @@ interface <dfn>HTMLAudioElement</dfn> : <span>HTMLMediaElement</span> {};</pre>

<hr>

<p>Each <span>media element</span> has a <span>list of newly
introduced cues</span>, which must be initially empty. Whenever a
<span>text track cue</span> is added to the <span title="text track
list of cues">list of cues</span> of a <span>text track</span> that
is in the <span>list of text tracks</span> for a <span>media
element</span>, that <span title="text track cue">cue</span> must be
added to the <span>media element</span>'s <span>list of newly
introduced cues</span>. Whenever a <span>text track</span> is added
to the <span>list of text tracks</span> for a <span>media
element</span>, all of the <span title="text track cue">cues</span>
in that <span>text track</span>'s <span title="text track list of
cues">list of cues</span> must be added to the <span>media
element</span>'s <span>list of newly introduced cues</span>.</p>

<p>When the <span>current playback position</span> of a <span>media
element</span> changes (e.g. due to playback or seeking), the user
agent must run the following steps. If the <span>current playback
Expand Down Expand Up @@ -34675,6 +34689,12 @@ interface <dfn>HTMLAudioElement</dfn> : <span>HTMLMediaElement</span> {};</pre>
equal to the <span>current playback position</span>. Otherwise, let
<var title="">missed cues</var> be an empty list.</p></li>

<li><p>Remove all the <span title="text track cue">cues</span> in
<var title="">missed cues</var> that are also in the <span>media
element</span>'s <span>list of newly introduced cues</span>, and
then empty the element's <span>list of newly introduced
cues</span>.</p></li>

<li><p>If the time was reached through the usual monotonic increase
of the <span>current playback position</span> during normal
playback, and if the user agent has not fired a <code
Expand Down

0 comments on commit 89d50d4

Please sign in to comment.