[giow] (0) Try adding a fourth argument, 'column', to onerror handlers.

Fixing https://www.w3.org/Bugs/Public/show_bug.cgi?id=13319 Affected topics: HTML, Web Workers git-svn-id: http://svn.whatwg.org/webapps@6957 340c8d12-0b0e-0410-8428-c7bf67bfef74
whatwg · Jan 31, 2012 · 318db56 · 318db56
1 parent a38c0ba
commit 318db56
Show file tree

Hide file tree

Showing 3 changed files with 67 additions and 54 deletions.
diff --git a/complete.html b/complete.html
@@ -67531,8 +67531,8 @@ <h5 id=creating-scripts><span class=secno>7.1.3.3 </span>Creating scripts</h5>
     entry-point</a></i>.</p>
 
     <p>Otherwise, <a href=#report-the-error>report the error</a> at the script source
-    URL, with the problematic line number, in the script's
-    <a href=#origin>origin</a>, using the <code title=handler-window-onerror><a href=#handler-window-onerror>onerror</a></code> <a href=#event-handlers title="event
+    URL, with the problematic position (line number and column
+    number), in the script's <a href=#origin>origin</a>, using the <code title=handler-window-onerror><a href=#handler-window-onerror>onerror</a></code> <a href=#event-handlers title="event
     handlers">event handler</a> of the <a href="#script's-global-object">script's global
     object</a>. If the error is still <i title=concept-error-nothandled><a href=#concept-error-nothandled>not handled</a></i> after this, then
     the error may be reported to the user.</p>
@@ -67616,7 +67616,7 @@ <h5 id=killing-scripts><span class=secno>7.1.3.4 </span>Killing scripts</h5>
   <h5 id=runtime-script-errors><span class=secno>7.1.3.5 </span>Runtime script errors</h5>
 
   <p>When the user agent is required to <dfn id=report-the-error title="report the
-  error">report an error</dfn> at a particular <a href=#url>URL</a> <var title="">location</var> with a particular line number <var title="">line</var> in a particular origin <var title="">origin</var>, using the <a href=#event-handlers title="event handlers">event
+  error">report an error</dfn> at a particular <a href=#url>URL</a> <var title="">location</var> with a particular position <var title="">line</var>:<var title="">col</var> in a particular origin <var title="">origin</var>, using the <a href=#event-handlers title="event handlers">event
   handler</a> <var title="">onerror</var>, it must run these steps,
   after which the error is either <dfn id=concept-error-handled title=concept-error-handled><i>handled</i></dfn> or <dfn id=concept-error-nothandled title=concept-error-nothandled><i>not handled</i></dfn>:</p>
 
@@ -67637,7 +67637,7 @@ <h5 id=runtime-script-errors><span class=secno>7.1.3.5 </span>Runtime script err
 
      <li>
 
-      <p>The function must be invoked with three arguments: <var title="">message</var>, <var title="">location</var>, and <var title="">line</var>.</p>
+      <p>The function must be invoked with four arguments: <var title="">message</var>, <var title="">location</var>, <var title="">line</var>, and <var title="">col</var>.</p>
 
       <p>If the function returns true, then the error is <i title=concept-error-handled><a href=#concept-error-handled>handled</a></i>. Otherwise, the error is
       <i title=concept-error-nothandled><a href=#concept-error-nothandled>not handled</a></i>.</p>
@@ -67666,8 +67666,9 @@ <h5 id=runtime-script-errors><span class=secno>7.1.3.5 </span>Runtime script err
   scripts associated with a <code><a href=#document>Document</a></code>, the user agent must
   <a href=#report-the-error>report the error</a> at the URL of the resource containing
   the script (as established when the <a href=#concept-script title=concept-script>script</a> was <a href=#create-a-script title="create a
-  script">created</a>), with the problematic line number in that
-  resource, in the script's <a href=#origin>origin</a>, using the <code title=handler-window-onerror><a href=#handler-window-onerror>onerror</a></code> <a href=#event-handlers title="event
+  script">created</a>), with the problematic position (line number
+  and column number) in that resource, in the script's
+  <a href=#origin>origin</a>, using the <code title=handler-window-onerror><a href=#handler-window-onerror>onerror</a></code> <a href=#event-handlers title="event
   handlers">event handler</a> of the <a href="#script's-global-object">script's global
   object</a>. If the error is still <i title=concept-error-nothandled><a href=#concept-error-nothandled>not handled</a></i> after this, then
   the error may be reported to the user.</p>
@@ -68269,7 +68270,8 @@ <h5 id=event-handler-attributes><span class=secno>7.1.6.1 </span>Event handlers<
       <dl class=switch><dt>If the attribute is the <code title=handler-window-onerror><a href=#handler-window-onerror>onerror</a></code> attribute of the
        <code><a href=#window>Window</a></code> object</dt>
 
-       <dd>Let the function have three arguments, named <code title="">event</code>, <code title="">source</code>, and <code title="">lineno</code>.</dd>
+       <dd>Let the function have four arguments, named <code title="">event</code>, <code title="">source</code>, <code title="">lineno</code>, and <code title="">column</code>.</dd>
+       <!-- /column/ is new as of 2012; see https://www.w3.org/Bugs/Public/show_bug.cgi?id=13319 -->
 
        <dt>Otherwise</dt>
 
@@ -68412,12 +68414,13 @@ <h5 id=event-handler-attributes><span class=secno>7.1.6.1 </span>Event handlers<
    <li><p>If <var title="">H</var>'s value is an <a href=#concept-handler-error title=concept-handler-error>internal error value</a>, then set
    the <a href=#event-handlers title="event handlers">event handler</a> to null and
    then <a href=#report-the-error>report the error</a> at the appropriate URL and with
-   the appropriate line number, as established when the error was
-   detected, in the <a href=#origin>origin</a> of the <code><a href=#document>Document</a></code>
-   of the node of the <a href=#event-handler-content-attributes title="event handler content
-   attributes">event handler content attribute</a>, using the <code title=handler-window-onerror><a href=#handler-window-onerror>onerror</a></code> <a href=#event-handlers title="event
-   handlers">event handler</a> of the <code><a href=#window>Window</a></code> object of
-   that <code><a href=#document>Document</a></code>, and abort these steps.</li>
+   the appropriate position (line number and column number), as
+   established when the error was detected, in the <a href=#origin>origin</a>
+   of the <code><a href=#document>Document</a></code> of the node of the <a href=#event-handler-content-attributes title="event
+   handler content attributes">event handler content attribute</a>,
+   using the <code title=handler-window-onerror><a href=#handler-window-onerror>onerror</a></code> <a href=#event-handlers title="event handlers">event handler</a> of the
+   <code><a href=#window>Window</a></code> object of that <code><a href=#document>Document</a></code>, and abort
+   these steps.</li>
 
    <li><p>Let <var title="">callback</var> be <var title="">H</var>'s
    value, the <code><a href=#function>Function</a></code> object that the <a href=#event-handlers title="event
@@ -75793,9 +75796,10 @@ <h4 id=runtime-script-errors-0><span class=secno>9.2.6 </span>Runtime script err
   worker's scripts, if the error did not occur while handling a
   previous script error, the user agent must <a href=#report-the-error>report the
   error</a> at the <a href=#url>URL</a> of the resource that contained
-  the script, with the line number where the error occurred, in the
-  <a href=#origin>origin</a> of the scripts running in the worker, using the
-  <code><a href=#workerglobalscope>WorkerGlobalScope</a></code> object's <code title=handler-WorkerGlobalScope-onerror><a href=#handler-workerglobalscope-onerror>onerror</a></code> attribute.
+  the script, with the position (line number and column number) where
+  the error occurred, in the <a href=#origin>origin</a> of the scripts
+  running in the worker, using the <code><a href=#workerglobalscope>WorkerGlobalScope</a></code>
+  object's <code title=handler-WorkerGlobalScope-onerror><a href=#handler-workerglobalscope-onerror>onerror</a></code> attribute.
   </p>
 
   <p>For shared workers, if the error is still <i title=concept-error-nothandled><a href=#concept-error-nothandled>not handled</a></i> afterwards, or if

diff --git a/index b/index
@@ -67531,8 +67531,8 @@ interface <dfn id=navigatoronline>NavigatorOnLine</dfn> {
     entry-point</a></i>.</p>
 
     <p>Otherwise, <a href=#report-the-error>report the error</a> at the script source
-    URL, with the problematic line number, in the script's
-    <a href=#origin>origin</a>, using the <code title=handler-window-onerror><a href=#handler-window-onerror>onerror</a></code> <a href=#event-handlers title="event
+    URL, with the problematic position (line number and column
+    number), in the script's <a href=#origin>origin</a>, using the <code title=handler-window-onerror><a href=#handler-window-onerror>onerror</a></code> <a href=#event-handlers title="event
     handlers">event handler</a> of the <a href="#script's-global-object">script's global
     object</a>. If the error is still <i title=concept-error-nothandled><a href=#concept-error-nothandled>not handled</a></i> after this, then
     the error may be reported to the user.</p>
@@ -67616,7 +67616,7 @@ interface <dfn id=navigatoronline>NavigatorOnLine</dfn> {
   <h5 id=runtime-script-errors><span class=secno>7.1.3.5 </span>Runtime script errors</h5>
 
   <p>When the user agent is required to <dfn id=report-the-error title="report the
-  error">report an error</dfn> at a particular <a href=#url>URL</a> <var title="">location</var> with a particular line number <var title="">line</var> in a particular origin <var title="">origin</var>, using the <a href=#event-handlers title="event handlers">event
+  error">report an error</dfn> at a particular <a href=#url>URL</a> <var title="">location</var> with a particular position <var title="">line</var>:<var title="">col</var> in a particular origin <var title="">origin</var>, using the <a href=#event-handlers title="event handlers">event
   handler</a> <var title="">onerror</var>, it must run these steps,
   after which the error is either <dfn id=concept-error-handled title=concept-error-handled><i>handled</i></dfn> or <dfn id=concept-error-nothandled title=concept-error-nothandled><i>not handled</i></dfn>:</p>
 
@@ -67637,7 +67637,7 @@ interface <dfn id=navigatoronline>NavigatorOnLine</dfn> {
 
      <li>
 
-      <p>The function must be invoked with three arguments: <var title="">message</var>, <var title="">location</var>, and <var title="">line</var>.</p>
+      <p>The function must be invoked with four arguments: <var title="">message</var>, <var title="">location</var>, <var title="">line</var>, and <var title="">col</var>.</p>
 
       <p>If the function returns true, then the error is <i title=concept-error-handled><a href=#concept-error-handled>handled</a></i>. Otherwise, the error is
       <i title=concept-error-nothandled><a href=#concept-error-nothandled>not handled</a></i>.</p>
@@ -67666,8 +67666,9 @@ interface <dfn id=navigatoronline>NavigatorOnLine</dfn> {
   scripts associated with a <code><a href=#document>Document</a></code>, the user agent must
   <a href=#report-the-error>report the error</a> at the URL of the resource containing
   the script (as established when the <a href=#concept-script title=concept-script>script</a> was <a href=#create-a-script title="create a
-  script">created</a>), with the problematic line number in that
-  resource, in the script's <a href=#origin>origin</a>, using the <code title=handler-window-onerror><a href=#handler-window-onerror>onerror</a></code> <a href=#event-handlers title="event
+  script">created</a>), with the problematic position (line number
+  and column number) in that resource, in the script's
+  <a href=#origin>origin</a>, using the <code title=handler-window-onerror><a href=#handler-window-onerror>onerror</a></code> <a href=#event-handlers title="event
   handlers">event handler</a> of the <a href="#script's-global-object">script's global
   object</a>. If the error is still <i title=concept-error-nothandled><a href=#concept-error-nothandled>not handled</a></i> after this, then
   the error may be reported to the user.</p>
@@ -68269,7 +68270,8 @@ currently this is unnecessary: http://www.w3.org/Bugs/Public/show_bug.cgi?id=119
       <dl class=switch><dt>If the attribute is the <code title=handler-window-onerror><a href=#handler-window-onerror>onerror</a></code> attribute of the
        <code><a href=#window>Window</a></code> object</dt>
 
-       <dd>Let the function have three arguments, named <code title="">event</code>, <code title="">source</code>, and <code title="">lineno</code>.</dd>
+       <dd>Let the function have four arguments, named <code title="">event</code>, <code title="">source</code>, <code title="">lineno</code>, and <code title="">column</code>.</dd>
+       <!-- /column/ is new as of 2012; see https://www.w3.org/Bugs/Public/show_bug.cgi?id=13319 -->
 
        <dt>Otherwise</dt>
 
@@ -68412,12 +68414,13 @@ currently this is unnecessary: http://www.w3.org/Bugs/Public/show_bug.cgi?id=119
    <li><p>If <var title="">H</var>'s value is an <a href=#concept-handler-error title=concept-handler-error>internal error value</a>, then set
    the <a href=#event-handlers title="event handlers">event handler</a> to null and
    then <a href=#report-the-error>report the error</a> at the appropriate URL and with
-   the appropriate line number, as established when the error was
-   detected, in the <a href=#origin>origin</a> of the <code><a href=#document>Document</a></code>
-   of the node of the <a href=#event-handler-content-attributes title="event handler content
-   attributes">event handler content attribute</a>, using the <code title=handler-window-onerror><a href=#handler-window-onerror>onerror</a></code> <a href=#event-handlers title="event
-   handlers">event handler</a> of the <code><a href=#window>Window</a></code> object of
-   that <code><a href=#document>Document</a></code>, and abort these steps.</li>
+   the appropriate position (line number and column number), as
+   established when the error was detected, in the <a href=#origin>origin</a>
+   of the <code><a href=#document>Document</a></code> of the node of the <a href=#event-handler-content-attributes title="event
+   handler content attributes">event handler content attribute</a>,
+   using the <code title=handler-window-onerror><a href=#handler-window-onerror>onerror</a></code> <a href=#event-handlers title="event handlers">event handler</a> of the
+   <code><a href=#window>Window</a></code> object of that <code><a href=#document>Document</a></code>, and abort
+   these steps.</li>
 
    <li><p>Let <var title="">callback</var> be <var title="">H</var>'s
    value, the <code><a href=#function>Function</a></code> object that the <a href=#event-handlers title="event
@@ -75793,9 +75796,10 @@ interface <dfn id=workerglobalscope>WorkerGlobalScope</dfn> : <a href=#eventtarg
   worker's scripts, if the error did not occur while handling a
   previous script error, the user agent must <a href=#report-the-error>report the
   error</a> at the <a href=#url>URL</a> of the resource that contained
-  the script, with the line number where the error occurred, in the
-  <a href=#origin>origin</a> of the scripts running in the worker, using the
-  <code><a href=#workerglobalscope>WorkerGlobalScope</a></code> object's <code title=handler-WorkerGlobalScope-onerror><a href=#handler-workerglobalscope-onerror>onerror</a></code> attribute.
+  the script, with the position (line number and column number) where
+  the error occurred, in the <a href=#origin>origin</a> of the scripts
+  running in the worker, using the <code><a href=#workerglobalscope>WorkerGlobalScope</a></code>
+  object's <code title=handler-WorkerGlobalScope-onerror><a href=#handler-workerglobalscope-onerror>onerror</a></code> attribute.
   </p>
 
   <p>For shared workers, if the error is still <i title=concept-error-nothandled><a href=#concept-error-nothandled>not handled</a></i> afterwards, or if