[e] (0) Comment out the onchange='' handler since it's poor practice.

Fixing http://www.w3.org/Bugs/Public/show_bug.cgi?id=8679 git-svn-id: http://svn.whatwg.org/webapps@4663 340c8d12-0b0e-0410-8428-c7bf67bfef74
whatwg · Feb 5, 2010 · b526c89 · b526c89
1 parent 7ecc803
commit b526c89
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/complete.html b/complete.html
@@ -43490,9 +43490,9 @@ <h5 id=menus-intro><span class=secno>4.11.4.1 </span>Introduction</h5>
  &lt;menu type="toolbar"&gt;
   &lt;label for="goto"&gt;Go to...&lt;/label&gt;
   &lt;menu label="Go"&gt;
-   &lt;select id="goto"
+   &lt;select id="goto"<!--
            onchange="if (this.options[this.selectedIndex].value)
-                     window.location = this.options[this.selectedIndex].value"&gt;
+                     window.location = this.options[this.selectedIndex].value"-->&gt;
     &lt;option value="" selected="selected"&gt; Select site: &lt;/option&gt;
     &lt;option value="http://www.apple.com/"&gt; Apple &lt;/option&gt;
     &lt;option value="http://www.mozilla.org/"&gt; Mozilla &lt;/option&gt;

diff --git a/index b/index
@@ -43389,9 +43389,9 @@ interface <dfn>DataGridListener</dfn> {
  &lt;menu type="toolbar"&gt;
   &lt;label for="goto"&gt;Go to...&lt;/label&gt;
   &lt;menu label="Go"&gt;
-   &lt;select id="goto"
+   &lt;select id="goto"<!--
            onchange="if (this.options[this.selectedIndex].value)
-                     window.location = this.options[this.selectedIndex].value"&gt;
+                     window.location = this.options[this.selectedIndex].value"-->&gt;
     &lt;option value="" selected="selected"&gt; Select site: &lt;/option&gt;
     &lt;option value="http://www.apple.com/"&gt; Apple &lt;/option&gt;
     &lt;option value="http://www.mozilla.org/"&gt; Mozilla &lt;/option&gt;

diff --git a/source b/source
@@ -48385,9 +48385,9 @@ interface <dfn>DataGridListener</dfn> {
  &lt;menu type="toolbar"&gt;
   &lt;label for="goto"&gt;Go to...&lt;/label&gt;
   &lt;menu label="Go"&gt;
-   &lt;select id="goto"
+   &lt;select id="goto"<!--
            onchange="if (this.options[this.selectedIndex].value)
-                     window.location = this.options[this.selectedIndex].value"&gt;
+                     window.location = this.options[this.selectedIndex].value"-->&gt;
     &lt;option value="" selected="selected"&gt; Select site: &lt;/option&gt;
     &lt;option value="http://www.apple.com/"&gt; Apple &lt;/option&gt;
     &lt;option value="http://www.mozilla.org/"&gt; Mozilla &lt;/option&gt;