Skip to content

Commit

Permalink
[giow] (0) showModalDialog() inside a sandboxed iframe should be bloc…
Browse files Browse the repository at this point in the history 
…ked _before_ the window pops up... Also, some minor editorial cleanup in this area.

Fixing http://www.w3.org/Bugs/Public/show_bug.cgi?id=12391

git-svn-id: http://svn.whatwg.org/webapps@6233 340c8d12-0b0e-0410-8428-c7bf67bfef74
  • Loading branch information
@Hixie
Hixie committed Jun 15, 2011
1 parent e455722 commit 83ededb
Show file tree
Hide file tree
Showing 3 changed files with 58 additions and 24 deletions.
27 changes: 19 additions & 8 deletions complete.html
View file
Expand Up @@ -24146,8 +24146,8 @@ <h4 id=the-iframe-element><span class=secno>4.8.2 </span>The <dfn><code>iframe</

<p>This flag also <a href=#sandboxWindowOpen>prevents content
from creating new auxiliary browsing contexts</a>, e.g. using the
<code title=attr-hyperlink-target><a href=#attr-hyperlink-target>target</a></code> attribute or the
<code title=dom-open><a href=#dom-open>window.open()</a></code> method.</p>
<code title=attr-hyperlink-target><a href=#attr-hyperlink-target>target</a></code> attribute, the
<code title=dom-open><a href=#dom-open>window.open()</a></code> method, or the <code title=dom-showModalDialog><a href=#dom-showmodaldialog>showModalDialog()</a></code> method.</p>

</dd>

Expand Down Expand Up @@ -61283,10 +61283,11 @@ <h4 id=browsing-context-names><span class=secno>6.1.6 </span>Browsing context na
<li>

<p>Otherwise, a new browsing context is being requested, and what
happens depends on the user agent's configuration and/or
abilities:</p>
happens depends on the user agent's configuration and/or abilities
&mdash; it is determined by the rules given for the first
applicable option from the following list:</p>

<dl><dt id=sandboxWindowOpen>If the current browsing context had
<dl class=switch><dt id=sandboxWindowOpen>If the current browsing context had
the <a href=#sandboxed-navigation-browsing-context-flag>sandboxed navigation browsing context flag</a> set
when its <a href=#active-document>active document</a> was created.</dt>

Expand All @@ -61295,9 +61296,10 @@ <h4 id=browsing-context-names><span class=secno>6.1.6 </span>Browsing context na
browsing context</a>. If the user picks one of those options,
then the designated browsing context must be the chosen one (the
browsing context's name isn't set to the given browsing context
name). Otherwise (if the user agent doesn't offer the option to
the user, or if the user declines to allow a browsing context to
be used) there must not be a chosen browsing context.</dd>
name). The default behaviour (if the user agent doesn't offer the
option to the user, or if the user declines to allow a browsing
context to be used) there must not be a chosen browsing
context.</dd>


<dt id=noopener>If the user agent has been configured such that
Expand Down Expand Up @@ -69148,6 +69150,15 @@ <h4 id=dialogs-implemented-using-separate-documents><span class=secno>7.4.3 </sp

</li>

<li>

<p>If the current browsing context had the <a href=#sandboxed-navigation-browsing-context-flag>sandboxed
navigation browsing context flag</a> set when its <a href=#active-document>active
document</a> was created, then return the empty string and
abort these steps.</p>

</li>

<li>

<p>Let <var title="">the list of background browsing
Expand Down
27 changes: 19 additions & 8 deletions index
View file
Expand Up @@ -24136,8 +24136,8 @@ href="?audio"&gt;audio&lt;/a&gt; test instead.)&lt;/p&gt;</pre>

<p>This flag also <a href=#sandboxWindowOpen>prevents content
from creating new auxiliary browsing contexts</a>, e.g. using the
<code title=attr-hyperlink-target><a href=#attr-hyperlink-target>target</a></code> attribute or the
<code title=dom-open><a href=#dom-open>window.open()</a></code> method.</p>
<code title=attr-hyperlink-target><a href=#attr-hyperlink-target>target</a></code> attribute, the
<code title=dom-open><a href=#dom-open>window.open()</a></code> method, or the <code title=dom-showModalDialog><a href=#dom-showmodaldialog>showModalDialog()</a></code> method.</p>

</dd>

Expand Down Expand Up @@ -61276,10 +61276,11 @@ _:n2 hcard:adr%20street-address "Avenue Q" ;
<li>

<p>Otherwise, a new browsing context is being requested, and what
happens depends on the user agent's configuration and/or
abilities:</p>
happens depends on the user agent's configuration and/or abilities
&mdash; it is determined by the rules given for the first
applicable option from the following list:</p>

<dl><dt id=sandboxWindowOpen>If the current browsing context had
<dl class=switch><dt id=sandboxWindowOpen>If the current browsing context had
the <a href=#sandboxed-navigation-browsing-context-flag>sandboxed navigation browsing context flag</a> set
when its <a href=#active-document>active document</a> was created.</dt>

Expand All @@ -61288,9 +61289,10 @@ _:n2 hcard:adr%20street-address "Avenue Q" ;
browsing context</a>. If the user picks one of those options,
then the designated browsing context must be the chosen one (the
browsing context's name isn't set to the given browsing context
name). Otherwise (if the user agent doesn't offer the option to
the user, or if the user declines to allow a browsing context to
be used) there must not be a chosen browsing context.</dd>
name). The default behaviour (if the user agent doesn't offer the
option to the user, or if the user declines to allow a browsing
context to be used) there must not be a chosen browsing
context.</dd>


<dt id=noopener>If the user agent has been configured such that
Expand Down Expand Up @@ -69161,6 +69163,15 @@ interface <dfn id=windowtimers>WindowTimers</dfn> {

</li>

<li>

<p>If the current browsing context had the <a href=#sandboxed-navigation-browsing-context-flag>sandboxed
navigation browsing context flag</a> set when its <a href=#active-document>active
document</a> was created, then return the empty string and
abort these steps.</p>

</li>

<li>

<p>Let <var title="">the list of background browsing
Expand Down
28 changes: 20 additions & 8 deletions source
View file
Expand Up @@ -26090,8 +26090,9 @@ href="?audio">audio&lt;/a> test instead.)&lt;/p></pre>

<p>This flag also <a href="#sandboxWindowOpen">prevents content
from creating new auxiliary browsing contexts</a>, e.g. using the
<code title="attr-hyperlink-target">target</code> attribute or the
<code title="dom-open">window.open()</code> method.</p>
<code title="attr-hyperlink-target">target</code> attribute, the
<code title="dom-open">window.open()</code> method, or the <code
title="dom-showModalDialog">showModalDialog()</code> method.</p>

</dd>

Expand Down Expand Up @@ -69840,10 +69841,11 @@ _:n2 hcard:adr%20street-address "Avenue Q" ;
<li>

<p>Otherwise, a new browsing context is being requested, and what
happens depends on the user agent's configuration and/or
abilities:</p>
happens depends on the user agent's configuration and/or abilities
&mdash; it is determined by the rules given for the first
applicable option from the following list:</p>

<dl>
<dl class="switch">

<dt id="sandboxWindowOpen">If the current browsing context had
the <span>sandboxed navigation browsing context flag</span> set
Expand All @@ -69854,9 +69856,10 @@ _:n2 hcard:adr%20street-address "Avenue Q" ;
browsing context</span>. If the user picks one of those options,
then the designated browsing context must be the chosen one (the
browsing context's name isn't set to the given browsing context
name). Otherwise (if the user agent doesn't offer the option to
the user, or if the user declines to allow a browsing context to
be used) there must not be a chosen browsing context.</p></dd>
name). The default behaviour (if the user agent doesn't offer the
option to the user, or if the user declines to allow a browsing
context to be used) there must not be a chosen browsing
context.</p></dd>


<dt id="noopener">If the user agent has been configured such that
Expand Down Expand Up @@ -78954,6 +78957,15 @@ interface <dfn>WindowTimers</dfn> {

</li>

<li>

<p>If the current browsing context had the <span>sandboxed
navigation browsing context flag</span> set when its <span>active
document</span> was created, then return the empty string and
abort these steps.</p>

</li>

<li>

<p>Let <var title="">the list of background browsing
Expand Down

0 comments on commit 83ededb

Please sign in to comment.