Skip to content

Commit

Permalink
[cgiowt] (3) PARSER: when inlining the fake tags, I missed that <sele…
Browse files Browse the repository at this point in the history
…ct>.innerHTML = '<select>' would crash if we did not check for a <select> in scope first

Affected topics: HTML Syntax and Parsing

git-svn-id: http://svn.whatwg.org/webapps@8667 340c8d12-0b0e-0410-8428-c7bf67bfef74
  • Loading branch information
Hixie committed Jun 10, 2014
1 parent b603fe8 commit 56a9a3f
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 2 deletions.
6 changes: 5 additions & 1 deletion complete.html
Expand Up @@ -290,7 +290,7 @@
</script><body onload=init()>
<header class="head with-buttons" id=head><p><a href=//www.whatwg.org/ class=logo><img width=101 src=/images/logo alt=WHATWG height=101></a></p>
<hgroup><h1 class=allcaps>HTML</h1>
<h2 class="no-num no-toc">Living Standard &mdash; Last Updated 9 June 2014</h2>
<h2 class="no-num no-toc">Living Standard &mdash; Last Updated 10 June 2014</h2>
</hgroup><div>
<div>
<a href=//whatwg.org/html><span><strong>Multipage Version</strong> <code>whatwg.org/html</code></span></a>
Expand Down Expand Up @@ -94050,6 +94050,10 @@ <h6 id=parsing-main-inselect><span class=secno>12.2.5.4.16 </span>The "<dfn titl
<p><a href=#parse-error>Parse error</a>.</p>

<!-- fake </select> -->
<p>If the <a href=#stack-of-open-elements>stack of open elements</a> does not <a href=#has-an-element-in-select-scope title="has an element in select
scope">have a <code>select</code> element in select scope</a>, ignore the token.
(<a href=#fragment-case>fragment case</a>)</p>

<p>Pop elements from the <a href=#stack-of-open-elements>stack of open elements</a> until a <code><a href=#the-select-element>select</a></code> element
has been popped from the stack.</p>

Expand Down
6 changes: 5 additions & 1 deletion index
Expand Up @@ -290,7 +290,7 @@
</script><body onload=init()>
<header class="head with-buttons" id=head><p><a href=//www.whatwg.org/ class=logo><img width=101 src=/images/logo alt=WHATWG height=101></a></p>
<hgroup><h1 class=allcaps>HTML</h1>
<h2 class="no-num no-toc">Living Standard &mdash; Last Updated 9 June 2014</h2>
<h2 class="no-num no-toc">Living Standard &mdash; Last Updated 10 June 2014</h2>
</hgroup><div>
<div>
<a href=//whatwg.org/html><span><strong>Multipage Version</strong> <code>whatwg.org/html</code></span></a>
Expand Down Expand Up @@ -94050,6 +94050,10 @@ document.body.appendChild(text);
<p><a href=#parse-error>Parse error</a>.</p>

<!-- fake </select> -->
<p>If the <a href=#stack-of-open-elements>stack of open elements</a> does not <a href=#has-an-element-in-select-scope title="has an element in select
scope">have a <code>select</code> element in select scope</a>, ignore the token.
(<a href=#fragment-case>fragment case</a>)</p>

<p>Pop elements from the <a href=#stack-of-open-elements>stack of open elements</a> until a <code><a href=#the-select-element>select</a></code> element
has been popped from the stack.</p>

Expand Down
4 changes: 4 additions & 0 deletions source
Expand Up @@ -103727,6 +103727,10 @@ document.body.appendChild(text);
<p><span>Parse error</span>.</p>

<!-- fake </select> -->
<p>If the <span>stack of open elements</span> does not <span data-x="has an element in select
scope">have a <code>select</code> element in select scope</span>, ignore the token.
(<span>fragment case</span>)</p>

<p>Pop elements from the <span>stack of open elements</span> until a <code>select</code> element
has been popped from the stack.</p>

Expand Down

0 comments on commit 56a9a3f

Please sign in to comment.